Implement unbind from managed service instance #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| BindingRequestedCondition = "BindingRequested" | ||
| BindingFailedCondition = "BindingFailed" | ||
|
|
||
| // TODO: remove UnbindingRequestedCondition |
- Added IsAsync flag to UnbindResponse in OSBAPI and the logic in the Unbind method - Added returning Gone error and ignoring in instances and bindings controllers - Implementing the Unbind call in binding controller and also polling the last operation for the unbind response - Refactor binding controller so that the calls for the Bind, Unbind and Provison and Deprovision in the services controller are identical - Implement Setting owner reference with BlockOwnerDeletion=true and added 'foregroundDeletion' finalizer in binding controller fixes cloudfoundry#3296 Co-authored-by: Danail Branekov <[email protected]>
uzabanov
force-pushed
the
issues/3296-unbind-from-managed-instance
branch
from
15d2c4d to
8bfde5d
Compare
danail-branekov
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3296
Is there a related GitHub Issue?
#3296
Does this PR introduce a breaking change?
No